(maint) Updating changelog generator config #1280
Conversation
|
Note - failures in spec tests are unrelated to this PR. |
|
I'd recommend just fixing the formatting of line 1 of the HISTORY.MD file. Then |
Fix to what? |
I think just adding a release date in brackets should do it. Will have a go later. |
Actually, it's fine as is (without adding a date). It's already being correctly parsed from HISTORY.md. |
.sync.yml
Outdated
| @@ -10,6 +10,7 @@ Gemfile: | |||
| - gem: github_changelog_generator | |||
| Rakefile: | |||
| changelog_user: puppetlabs | |||
| changelog_since_tag: '5.3.0' | |||
There was a problem hiding this comment.
This is actually redundant. The HISTORY.md file is formatted in such a way that this will be automatically discovered.
Rakefile
Outdated
| @@ -48,6 +48,7 @@ if Bundler.rubygems.find_name('github_changelog_generator').any? | |||
| raise "Set CHANGELOG_GITHUB_TOKEN environment variable eg 'export CHANGELOG_GITHUB_TOKEN=valid_token_here'" if Rake.application.top_level_tasks.include? "changelog" and ENV['CHANGELOG_GITHUB_TOKEN'].nil? | |||
| config.user = "#{changelog_user}" | |||
| config.project = "#{changelog_project}" | |||
| config.since_tag = "5.3.0" | |||
There was a problem hiding this comment.
This line can go too.
pmcmaw
force-pushed
the
maint/main/update_changelog_config
branch
from
be1b85d to
bcc1181
Compare
…gelog_config (maint) Updating changelog generator config
Following discussion, with the HISTORY.md file formatting (## 5.3.0) the changelog generator is clever enough to pick it up as the since_tag therefore the only change made here is to remove and
.github_changelog_generatorfile.